[PATCH] D100485: [AArch64][SVE] Fix crash with icmp+select

[Sander de Smalen via Phabricator via llvm-commits]

sdesmalen added a comment.

Can you also add support for predicates?

This currently also fails:

  define <vscale x 16 x i1> @icmp_select_nxv16i1(<vscale x 16 x i1> %a, <vscale x 16 x i1> %b, i64 %x0) {
    %mask = icmp eq i64 %x0, 0
    %sel = select i1 %mask, <vscale x 16 x i1> %a, <vscale x 16 x i1> %b
    ret <vscale x 16 x i1> %sel
  }



================
Comment at: llvm/test/CodeGen/AArch64/select-sve.ll:550
+
+define <vscale x 16 x i64> @icmp_select_nxv16i64(<vscale x 16 x i64> %a, <vscale x 16 x i64> %b, i64 %x0) {
+; CHECK-LABEL: icmp_select_nxv16i64
----------------
I don't think testing these wider types is necessary, as they will just rely on splitting the `select`, for which we already have tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100485/new/

https://reviews.llvm.org/D100485