[PATCH] D100488: [SystemZ][z/OS] Add IsText Argument to GetFile and GetFileOrSTDIN
Adrian McCarthy via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Apr 14 12:03:53 PDT 2021
amccarth accepted this revision.
amccarth added a comment.
This revision is now accepted and ready to land.
Personally, I'm not a fan of boolean function parameters because of the inline comments necessary to make the call site understandable. But it appears to be consistent with LLVM Coding Standards and other APIs, so this looks right to me.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100488/new/
https://reviews.llvm.org/D100488
More information about the llvm-commits
mailing list