[PATCH] D100388: [BROKEN][clang] Try to fix thunk function types

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added inline comments.


================
Comment at: clang/lib/AST/VTableBuilder.cpp:1155-1157
+      // Override it. Note that there may or may not be a thunk already.
+      VTableThunks.erase(Idx);
+      VTableThunks.insert({Idx, *TI});
----------------
rsmith wrote:
> Can you modify the thunk info in-place, instead of this erase + insert dance?
Absolutely. I had to change that because i needed to weed out all the places where `Thunk` is created.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100388/new/

https://reviews.llvm.org/D100388