[PATCH] D69428: [GlobalOpt] Remove valgrind specific hacks (revert r160529)

Chris Lattner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 14 11:35:57 PDT 2021


lattner added a comment.

I agree that this patch is the right direction.  The original one was quite unprincipled.  I appreciate the deleted code as well :-)



================
Comment at: llvm/test/Transforms/GlobalOpt/dead-store-status.ll:1
-; RUN: opt < %s -globalopt -S | FileCheck %s
+; RUN: opt < %s -globalopt -instcombine -S | FileCheck %s
 
----------------
Please don't add a dependency on instcombine here, this should be a unit test for globalopt alone.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69428/new/

https://reviews.llvm.org/D69428



More information about the llvm-commits mailing list