[PATCH] D100371: [debug-info] SCCP should preserve the debug location for an one-to-one instruction replacement

Wed Apr 14 08:47:16 PDT 2021

djtodoro added a comment.

In D100371#2689076 <https://reviews.llvm.org/D100371#2689076>, @yuanboli233 wrote:

> Yes, @djtodoro, it is in the starting phase, and we plan to improve it and make it an open-source project.

OK, thanks.

> For the BranchInst case you mentioned, currently, I don't have a test case for it yet. Let me check whether I can generate a test case for it quickly to illustrate the problem. or do you think it is fine to modify it without an illustrating test case?

We need a test case for sure.
I've just compiled GDB project with `-Xclang -fverify-debuginfo-preserve` enabled, and found out that some zext and branches don't have !dbg after SCCP. (I haven't taken a closer look into the SCCP to see if the !dbg is valid to the new branch).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100371/new/

https://reviews.llvm.org/D100371