[PATCH] D98240: [VectorCombine] Simplify to scalar store if only one element updated

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 14 06:53:18 PDT 2021


lebedev.ri added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/VectorCombine.cpp:53-54
 
+static cl::opt<unsigned> IterationThreshold(
+    "vector-combine-iteration-threshold", cl::init(100), cl::Hidden,
+    cl::desc("Max number of instructions to scan for vector combining."));
----------------
Option name doesn't match the description/usage.
Iteration, to me, means how many times we will rerun this whole pass,
while you use it as a number of instructions to scan.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98240/new/

https://reviews.llvm.org/D98240



More information about the llvm-commits mailing list