[PATCH] D93762: SCCP: Refactor SCCPSolver

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 14 06:35:29 PDT 2021


fhahn accepted this revision.
fhahn added a comment.

Thanks for the update, this is along the lines I had in mind. This might be an incentive to further review what is exposed in `SCCPSolver` and why.



================
Comment at: llvm/include/llvm/Transforms/Utils/SCCPSolver.h:45
+class SCCPSolver {
+  SCCPInstVisitor *Visitor;
+
----------------
can this be just a `unique_ptr`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93762/new/

https://reviews.llvm.org/D93762



More information about the llvm-commits mailing list