[PATCH] D100380: [Polly] In getBuild() use isl::noexception bindings

Riccardo Mori via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 14 06:17:03 PDT 2021


patacca added a comment.

Always use `isl::manage()` and `isl::manage_copy()` when constructing a C++ isl object from a raw C pointer



================
Comment at: polly/lib/CodeGen/IslAst.cpp:660
+  isl::ast_build Build =
+      Payload ? isl::ast_build(Payload->Build) : isl::ast_build(nullptr);
+  return Build;
----------------
You should use `isl::manage()` to initialize a `isl::ast_build` object. The constructor you are using is a private method


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100380/new/

https://reviews.llvm.org/D100380



More information about the llvm-commits mailing list