[PATCH] D100383: [LSR] Fix for pre-indexed generated constant offset

Wed Apr 14 05:49:40 PDT 2021

stelios-arm added a comment.

In D100383#2688643 <https://reviews.llvm.org/D100383#2688643>, @SjoerdMeijer wrote:

> And forgot to add, and just double checking, this passes your bootstrap build and test again?

Yes this compiles the bootstrap build and the `test-suite` too.

================
Comment at: llvm/test/Transforms/LoopStrengthReduce/AArch64/pre-inc-offset-check.ll:6
+
+define void @test_pre_inc(%"Type"* %p) {
+; CHECK-LABEL: test_pre_inc:
----------------
SjoerdMeijer wrote:
> Thanks for adding this, nice reproducer!
> 
> I think this tests could benefit from some comments explaining what exactly we are testing here. I.e., from the test name one might expect preindexed loads/store, but they don't appear in the codegen.
I will add some in the next revision. 

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100383/new/

https://reviews.llvm.org/D100383