[PATCH] D100475: llvm-objdump: move SourcePrinter to shared file

Tim Northover via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 14 05:46:20 PDT 2021


t.p.northover created this revision.
Herald added subscribers: rupprecht, hiraditya, mgorny, mcrosier.
Herald added a reviewer: jhenderson.
Herald added a reviewer: MaskRay.
t.p.northover requested review of this revision.
Herald added a project: LLVM.

Interleaved source printing during disassembly is a useful feature, but all the classes for it live in `llvm-objdump.cpp` and can't be used by the (weirdly) separate `MachODumper.cpp`. This patch pretty mechanically moves the needed bits (and command-line options) into a shareable header and adds the needed hooks for MachO.


https://reviews.llvm.org/D100475

Files:
  llvm/lib/DebugInfo/Symbolize/SymbolizableObjectFile.cpp
  llvm/test/tools/llvm-objdump/MachO/AArch64/Inputs/interleaved-source-macho
  llvm/test/tools/llvm-objdump/MachO/AArch64/Inputs/interleaved-source-macho.c
  llvm/test/tools/llvm-objdump/MachO/AArch64/Inputs/interleaved-source-macho.dSYM/Contents/Info.plist
  llvm/test/tools/llvm-objdump/MachO/AArch64/Inputs/interleaved-source-macho.dSYM/Contents/Resources/DWARF/interleaved-source-macho
  llvm/test/tools/llvm-objdump/MachO/AArch64/interleaved-source.txt
  llvm/tools/llvm-objdump/CMakeLists.txt
  llvm/tools/llvm-objdump/MachODump.cpp
  llvm/tools/llvm-objdump/SourcePrinter.cpp
  llvm/tools/llvm-objdump/SourcePrinter.h
  llvm/tools/llvm-objdump/llvm-objdump.cpp
  llvm/tools/llvm-objdump/llvm-objdump.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D100475.337424.patch
Type: text/x-patch
Size: 56190 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210414/d817b32c/attachment.bin>


More information about the llvm-commits mailing list