[PATCH] D100383: [LSR] Fix for pre-indexed generated constant offset

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 14 05:08:15 PDT 2021


SjoerdMeijer added inline comments.


================
Comment at: llvm/test/Transforms/LoopStrengthReduce/AArch64/pre-inc-offset-check.ll:6
+
+define void @test_pre_inc(%"Type"* %p) {
+; CHECK-LABEL: test_pre_inc:
----------------
Thanks for adding this, nice reproducer!

I think this tests could benefit from some comments explaining what exactly we are testing here. I.e., from the test name one might expect preindexed loads/store, but they don't appear in the codegen.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100383/new/

https://reviews.llvm.org/D100383



More information about the llvm-commits mailing list