[PATCH] D99055: [llvm-objcopy] Refactor CopyConfig structure.

Alexey Lapshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 14 05:06:06 PDT 2021


avl added a comment.

ping. Colleagues, what is your opinion on the way how this refactoring should be done?

I think the solution presented in this patch is a good way, especially from the library interface perspective.
It separates options and passes only relevant options to format specific parts. So my suggestion is to integrate this patch.

But if that approach is not good I am fine to implement a simpler approach: when all options are in the same structure, the structure is divided into the chunks of the config(by comments) "these are for ELF", "these are for MachO".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99055/new/

https://reviews.llvm.org/D99055



More information about the llvm-commits mailing list