[PATCH] D99481: [InstCombine] Fix miscompile on GEP+load to icmp fold (PR45210)
Hyeongyu Kim via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Apr 14 04:22:13 PDT 2021
hyeongyukim added a comment.
The patch was a bit complicated becauseĀ it included the sext case, so I uploaded a patch that did not take that case into account. The sext case was for removing redundant operations, so the current patch is still correct.
================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp:289
+ IdxBeforeSext->getType()->getPrimitiveSizeInBits().getFixedSize() >=
+ PtrSize;
+ else
----------------
aqjune wrote:
> This is to avoid creating redundant expressions, right?
> Could you elaborate a bit more with an example?
Yes, I changed my comment.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99481/new/
https://reviews.llvm.org/D99481
More information about the llvm-commits
mailing list