[PATCH] D69428: [GlobalOpt] Remove valgrind specific hacks (revert r160529)

[Nuno Lopes via Phabricator via llvm-commits]

nlopes added a comment.

In D69428#2687372 <https://reviews.llvm.org/D69428#2687372>, @saugustine wrote:

> I went ahead and reverted. We can discuss a plan--hopefully the internal cleanup to obviate this will go smoothly.
>
> Let me know if there are more issues.

I think it's unfair what just happened here. Google had over a year to comment and ended up wasting people's time.

Can you please comment on why you can't use `__attribute__((__used__))`? If you want to keep this hack in LLVM, I think it would be helpful if we understood the reason. Thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69428/new/

https://reviews.llvm.org/D69428