[PATCH] D100458: Handle DW_FORM_strx[1-4] in llvm-dwp

Kim-Anh Tran via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 14 02:25:51 PDT 2021


kimanh added a comment.

Picking up patch by tamur: https://reviews.llvm.org/D75485

I've addressed the outstanding issues, i.e.:

1. Adding test cases for each error case in parseCompileUnitHeader(StringRef Info)
2. Changing the error message to reuse the message from Error in parseCompileUnitHeader(StringRef Info)
3. Adapted tests (minor change: test error message, and added required header info to unsupported_cu_index_version.s)

As it seems (https://reviews.llvm.org/D77143) llvm-dwp does not yet support a compile unit version of 5, which is used in DWARF5. Will investigate (any input is welcome) later. However, with this patch (originally from tamur), we can now generate dwps.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100458/new/

https://reviews.llvm.org/D100458



More information about the llvm-commits mailing list