[PATCH] D99487: [CodeGen] Port basic block sections from ELF to COFF

Wed Apr 14 02:11:58 PDT 2021

TaoPan added a comment.

In D99487#2687506 <https://reviews.llvm.org/D99487#2687506>, @tmsriram wrote:

> If it is easier for you to break this up, you can present exception handling in a separate patch with a clear "TODO:" at the appropriate places. That should be alright and is also easier to review.

I added "TODO:" for constructing exception section and cold section later.

> Great, please use the parent-child relationships to mark these patches.

I marked parent-child relationships.

> - Could you also please expand the summary of this patch?  I would write what extra was needed to port this from ELF to PE-COFF.

I expanded the summary, could you please have a  review?

> - Could you also talk about DebugInfo handling and CFI with PE-COFF and basic block sections?  Are these format agnostic and have you verified that they do the right thing? These were the biggest challenges for us when doing this for ELF.

No, I didn't verify DebugInfo handling and CFI with PE-COFF and basic block sections.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99487/new/

https://reviews.llvm.org/D99487