[PATCH] D100442: [flang][msvc] Fix compilation of RuntimeGtest tests.

Wed Apr 14 01:32:26 PDT 2021

awarzynski added a comment.

Thank you for submitting this @MehdiChinoune ! I'm a bit confused - what's specific about MSVC here and in the failure that you are seeing?

================
Comment at: flang/unittests/RuntimeGTest/CMakeLists.txt:21
   FortranRuntime
+  ${llvm_libs}
 )
----------------
This will basically add a new dependency for all configurations - how come this didn't fail before on other platforms? Also, there's a Flang buildbot worker that sets `LLVM_LINK_LLVM_DYLIB` to `On`: https://lab.llvm.org/buildbot/#/builders/135 and it's currently :green:. 

Separately, `Support` is added as a dependency for unit tests here: https://github.com/llvm/llvm-project/blob/main/llvm/cmake/modules/AddLLVM.cmake#L1452.

So, is this change really needed?

================
Comment at: flang/unittests/RuntimeGTest/CrashHandlerFixture.cpp:31
   static bool isCrashHanlderRegistered{false};
-  if (not isCrashHanlderRegistered)
+  if (!isCrashHanlderRegistered)
     Fortran::runtime::Terminator::RegisterCrashHandler(CatchCrash);
----------------
Is this change required to fix the build?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100442/new/

https://reviews.llvm.org/D100442