[PATCH] D100376: [ARM] Prevent phi-node-elimination from generating copy above t2WhileLoopStartLR

[Dave Green via Phabricator via llvm-commits]

dmgreen added inline comments.


================
Comment at: llvm/test/CodeGen/Thumb2/phi_prevent_copy.mir:2
+# NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py
+# RUN: llc -O1 -mtriple=arm-arm-none-eabi -mcpu=cortex-m55 -simplify-mir -run-pass=phi-node-elimination %s -o - | FileCheck %s
+--- |
----------------
Don't need to add -O1, or a cpu. You can use -mtriple=thumbv8.1m.main-none-eabi -mattr=+mve


================
Comment at: llvm/test/CodeGen/Thumb2/phi_prevent_copy.mir:25
+
+  attributes #0 = { nofree norecurse nounwind "frame-pointer"="all" "no-trapping-math"="true" "stack-protector-buffer-size"="8" "target-cpu"="cortex-m55" "target-features"="+armv8.1-m.main,+dsp,+fp-armv8d16,+fp-armv8d16sp,+fp16,+fp64,+fullfp16,+hwdiv,+lob,+mve,+mve.fp,+ras,+strict-align,+thumb-mode,+vfp2,+vfp2sp,+vfp3d16,+vfp3d16sp,+vfp4d16,+vfp4d16sp,-aes,-bf16,-cdecp0,-cdecp1,-cdecp2,-cdecp3,-cdecp4,-cdecp5,-cdecp6,-cdecp7,-crc,-crypto,-dotprod,-fp16fml,-hwdiv-arm,-i8mm,-sb,-sha2" }
+  attributes #1 = { argmemonly nofree nosync nounwind willreturn "target-cpu"="cortex-m55" }
----------------
Is this and the stuff below needed?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100376/new/

https://reviews.llvm.org/D100376