[PATCH] D100265: [Polly][NFC][DO NOT LAND YET] Refactoring IslAst and partially IslAstInfo to use isl++

[Michael Kruse via Phabricator via llvm-commits]

Meinersbur added a comment.

It is correct that the addition of move semantics was intended to be done eventually. Thus would be one of the things to do for the GSoC project.

Until then we accepted that without these move semantics, there are redundant calls to `*_copy` and `*_free` calls. More critically, it may lead to additional object copies when calling a __isl_take function, but the reference count is not 1 because of the redundant reference. However, these do not seem to be that significant for the overall performance, so while it could be better, we know that it cane be improved with better bindings. For `polly::IslAst::RunCondition`, there is always another reference to it (by `polly::IslAst::RunCondition`) so any __isl_take function will always need to make a copy and the only overhead are the additional  `*_copy` and `*_free` calls.

That is, don't worry about making additional copies for now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100265/new/

https://reviews.llvm.org/D100265