[PATCH] D69428: [GlobalOpt] Remove valgrind specific hacks (revert r160529)

[Sterling Augustine via Phabricator via llvm-commits]

saugustine added a comment.

I think it is a valid transformation.

On the other hand, all three leak checkers that we have tried don't cope with the transformation well at all, and having those work is a useful feature from a QOI point of view. One possibility would be to only do the optimization at, say, -O3, rather than at -O1. Suboptimal, but better than the current situation. Having asan to report a failure at O3 <https://reviews.llvm.org/owners/package/3/> that it doesn't at -O0 is a little weird, but better than nothing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69428/new/

https://reviews.llvm.org/D69428