[PATCH] D100147: [lld-macho] Re-root absolute input file paths if -syslibroot is specified

[Jez Ng via Phabricator via llvm-commits]

int3 marked 2 inline comments as done.
int3 added inline comments.


================
Comment at: lld/test/MachO/reroot-path.s:28-29
+# RUN: %lld -lSystem -syslibroot %t -force_load %t/foo.a -force_load %t/bar.a %t/test.o -o /dev/null -t | FileCheck %s -DDIR="%t/%:t"
+# RUN: %lld -lSystem -syslibroot %t %t/libfoo.dylib %t/%:t/libbar.dylib %t/test.o -o /dev/null -t | FileCheck %s -DDIR="%t/%:t"
+# RUN: %lld -lSystem -syslibroot %t -weak_library %t/libfoo.dylib -weak_library %t/libbar.dylib %t/test.o -o /dev/null -t | FileCheck %s -DDIR="%t/%:t"
+# RUN: echo "%t/libfoo.dylib" > %t/filelist
----------------
gkm wrote:
> int3 wrote:
> > gkm wrote:
> > > Almost there! These also need to drop the `%:t/` component and become `%t/libbar.dylib` on the lld command line.
> > It looks right to me as-is. Are you looking at the right version of the diff?
> Line 29 is good now with `%t/libbar.dylib`, but 28 still contains `%t/%:t/libbar.dylib`
ugh, yes. Sorry, not sure how I missed that


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100147/new/

https://reviews.llvm.org/D100147