[PATCH] D69428: [GlobalOpt] Remove valgrind specific hacks (revert r160529)

[Sterling Augustine via Phabricator via llvm-commits]

saugustine added a comment.

I don't know why the various people you added didn't respond. This is unfortunate.

As it happens, this change does regress a bunch of Google internal leak tests with some internal tools. As it also happens, we are working to replace these tools with lsan, but that won't happen for a bit longer, and I can't promise a timeline.

Not sure the best thing to do from here. From my perspective, in a perfect world, if we could revert it, that would be great. Leaks do happen in the cases that the original change mentions:

If we delete the variable, but don't eliminate the corresponding allocation, then that memory does leak.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69428/new/

https://reviews.llvm.org/D69428