[PATCH] D99938: [lit] Always quote arguments containing '[' on windows

[Reid Kleckner via Phabricator via llvm-commits]

rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm



================
Comment at: llvm/test/Other/lit-quoting.txt:18-19
+On Windows, with MSYS based tools, the following commands fail though:
+echo 'a[b\c\\d' | FileCheck %s --check-prefix=CHECK4
+echo "a[b\\c\\\\d" | FileCheck %s --check-prefix=CHECK4
+CHECK4: {{^a\[b\\c\\\\d$}}
----------------
RUN lines that don't work as expected are often written as RUNX: to disable them. Maybe that's an old convention.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99938/new/

https://reviews.llvm.org/D99938