[PATCH] D99572: [AArch64] [COFF] Properly produce cross-section relative relocations

Tue Apr 13 14:30:23 PDT 2021

mstorsjo added a comment.

In D99572#2686970 <https://reviews.llvm.org/D99572#2686970>, @mstorsjo wrote:

> In D99572#2686887 <https://reviews.llvm.org/D99572#2686887>, @rnk wrote:
>
>> lgtm, although I don't have deep expertise to do this with great confidence.
>
> Yeah it's a bit nonobvious code, but at least it's essentially equivalent to what we have on X86 (which I'd assume has been a fair bit more battle tested than these arch/OS combos).

Just for reference, these codepaths seems to originate in ed16477cb9f907bd3525ae99d787c5d448f8dc0b, and was refactored into its current place in 1da4529b15ed80e5d6c0b21d3ac46538fbcad87f and touched a bit more in 58173b97209bfc907dd0b47ecfc5ab7c1fe1f036.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99572/new/

https://reviews.llvm.org/D99572