[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

[Alexey Bader via Phabricator via llvm-commits]

bader marked 2 inline comments as done.
bader added inline comments.


================
Comment at: clang/include/clang/AST/Type.h:488
            (A == LangAS::opencl_global && (B == LangAS::opencl_global_device ||
                                            B == LangAS::opencl_global_host)) ||
            // Consider pointer size address spaces to be equivalent to default.
----------------
Anastasia wrote:
> bader wrote:
> > BTW, we need enable `global_device` and `global_host` attributes from https://reviews.llvm.org/D82174 for SYCL USM feature. I have following question regarding this: should I create a follow-up patch or we can enable all attributes for SYCL at once?
> It seems like they would just be extending the existing functionality and not redesigning what we do in this patch?
> 
> If that's the case let's keep it in a separate patch, but feel free to upload it even now.
> It seems like they would just be extending the existing functionality and not redesigning what we do in this patch?
> 
> If that's the case let's keep it in a separate patch, but feel free to upload it even now.

Added in https://reviews.llvm.org/D100396.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89909/new/

https://reviews.llvm.org/D89909