[PATCH] D99769: [funcattrs] Infer nosync from instruction walk

[Philip Reames via Phabricator via llvm-commits]

reames reopened this revision.
reames added a comment.
This revision is now accepted and ready to land.

Johannes,

Sorry for not replying to your points inline, phab makes that difficult for long intermixed replies.

I am glad to see that work is being done towards enabling Attributor by default.  So as to avoid duplicating a long comment, I will point you to my comment on that review (https://reviews.llvm.org/D100339#2686153) to explain my concerns on that direction.

On the broader topic, I am happy to discuss the workflow implications offline.  Honestly, I think you've got the wrong end of the stick here.  If I accept the premise of your argument, my actual takeaway is that I should resist all efforts to add experimental code before it has been widely discussed and accepted as the agreed upon path forward.  I think we can all agree that's not a desirable outcome.  I also think it's out of sync with long standing practice in the community.

Again, if you want to talk on the workflow stuff, let's talk offline.  There's a bunch of subtleties that is far too easy to loose in written conversation.  I, in particular, seem very prone to that.  :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99769/new/

https://reviews.llvm.org/D99769