[PATCH] D93762: SCCP: Refactor SCCPSolver

Tue Apr 13 06:34:51 PDT 2021

sanwou01 accepted this revision.
sanwou01 added a comment.
This revision is now accepted and ready to land.

Since this is mostly just moving pre-existing code, I think it's fine to address the style issues in a separate NFC commit. I believe all comments have been addressed, but please wait a day or two before committing in case there is anything else. LGTM.

================
Comment at: llvm/lib/Transforms/Utils/SCCPSolver.cpp:14
+
+#include "llvm/Analysis/ConstantFolding.h"
+#include "llvm/Analysis/InstructionSimplify.h"
----------------
SCCPSolver.h should definitely be included first, to ensure that the includes in SCCPSolver.h are complete.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93762/new/

https://reviews.llvm.org/D93762