[PATCH] D97909: [AIX] Allow safe for 32bit P8 VSX pattern matching
Nemanja Ivanovic via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Apr 13 04:28:32 PDT 2021
nemanjai accepted this revision.
nemanjai added a comment.
This revision is now accepted and ready to land.
LGTM aside from a couple of cosmetic nits that can be fixed on the commit.
================
Comment at: llvm/lib/Target/PowerPC/PPCInstrVSX.td:2191
+ // BE variable float 32-bit version
+ dag BE_32B_VFLOAT_PERM_VEC = (v16i8(LVSL(i32 ZERO), (RLWINM $Idx, 2, 0, 29)));
+ dag BE_32B_VFLOAT_PERMUTE = (VPERM $S, $S, BE_32B_VFLOAT_PERM_VEC);
----------------
Nit: spaces after operands.
================
Comment at: llvm/lib/Target/PowerPC/PPCInstrVSX.td:2207
+ dag BE_32B_VDOUBLE_PERMUTE = (v16i8 (VPERM (v16i8 (COPY_TO_REGCLASS $S, VRRC)),
+ (v16i8 (COPY_TO_REGCLASS $S, VRRC)),
+ BE_32B_VDWORD_PERM_VEC));
----------------
Nit: please align operands to VPERM here.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97909/new/
https://reviews.llvm.org/D97909
More information about the llvm-commits
mailing list