[PATCH] D99723: [ARM] Transforming memcpy to Tail predicated Loop

Malhar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 13 03:57:39 PDT 2021


malharJ marked an inline comment as done.
malharJ added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMBaseInstrInfo.h:370
+           MI->getOpcode() == ARM::t2DoLoopStartTP ||
+           MI->getOpcode() == ARM::t2WhileLoopStartLR;
   }
----------------
dmgreen wrote:
> malharJ wrote:
> > dmgreen wrote:
> > > Please split this out into a separate review. I think it makes sense (I'm pretty sure I remember writing it, it must have been lost in a refactoring).
> > Do you mean just this single line update as a separate review ?
> > 
> > 
> Yeah... it should preferably be a separate patch. Do you have a test case? Some reason why you changed it?
Ok, I've now created a separate patch for this: https://reviews.llvm.org/D100376


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99723/new/

https://reviews.llvm.org/D99723



More information about the llvm-commits mailing list