[PATCH] D99087: [RISCV] Fix stack slot for argument types (Bug 49500)

Fraser Cormack via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 13 02:56:21 PDT 2021


frasercrmck added a comment.

In D99087#2670691 <https://reviews.llvm.org/D99087#2670691>, @luismarques wrote:

> In D99087#2668857 <https://reviews.llvm.org/D99087#2668857>, @frasercrmck wrote:
>
>> Yes, fair enough. I've updated the diff to use the preferred type alignment. We can always revert for whatever reason. I'll try and take a look through the diffs later.
>
> Thanks. Also, it seems I was wrong, you do sometimes get smaller stack sizes despite `getPrefTypeAlign >= getEVTAlign`. Weird.

Yeah it's interesting. Sorry, I haven't had time to investigate yet. I'll do that today. Have you taken a look, by any chance?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99087/new/

https://reviews.llvm.org/D99087



More information about the llvm-commits mailing list