[PATCH] D100032: [X86][AMX] Add description of x86_amx to LangRef.

LuoYuanke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 12 23:44:31 PDT 2021


LuoYuanke added inline comments.


================
Comment at: llvm/docs/LangRef.rst:3149
+The x86_amx type represents a value held in an AMX tile register on an x86
+machine. The operations allowed on it are quite limited: stride load and store,
+zero, dot product. User-specified AMX instructions are represented as intrinsic.
----------------
fhahn wrote:
> II think it is not quite clear whether the supported operations are instructions or intrinsics. could you clarify? Does the verifier reject unsupported instructions with operands of `x86_amx` type?
> II think it is not quite clear whether the supported operations are instructions or intrinsics. could you clarify? Does the verifier reject unsupported instructions with operands of `x86_amx` type?

We didn't verify the unsupported instructions with operands of `x86_amx` type. I'll create a patch to do the verification.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100032/new/

https://reviews.llvm.org/D100032



More information about the llvm-commits mailing list