[PATCH] D99822: [lld-macho] Add support for arm64_32

[Greg McGary via Phabricator via llvm-commits]

gkm accepted this revision.
gkm added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lld/test/MachO/arm64-32-stubs.s:3-5
+## FIXME: This test is very similar to arm64-stubs.s, but has been split into a
+## separate file because llvm-objdump doesn't correctly symbolize arm64_32. In
+## particular, the "literal pool symbol address" comments are missing.
----------------
int3 wrote:
> gkm wrote:
> > Unifying this one seems within reach:
> > * omit the "literal pool symbol address" comments
> > * either ...
> > ** match `{{[wx]}}16` or
> > ** define a FileCheck macro with the proper register name
> I think the 'literal pool symbol address' comments are useful though -- they verify that the instructions are actually referring to the right pointers. That (unfortunately) isn't being checked in the arm64-32 test.
File a bug for `llvm-objdump` then.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99822/new/

https://reviews.llvm.org/D99822