[PATCH] D100166: [PowerPC] stop reverse mem op generation when the feeder has more than one users

ChenZheng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 12 19:45:23 PDT 2021


shchenz added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:14375
+    // instruction, it is not profitable to replace it with a reverse store as
+    // the reverse store has no DForm.
+    if (!SVN->hasOneUse())
----------------
nemanjai wrote:
> It is not clear why the fact that there is no D-Form makes this unprofitable.
> Perhaps:
> ```
> // If there are other uses of the shuffle, the swap cannot be avoided.
> // Forcing the use of an X-Form (since swapped stores only have 
> // X-Forms) without removing the swap is unprofitable.
> ```
Thanks. It was updated in the commit.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100166/new/

https://reviews.llvm.org/D100166



More information about the llvm-commits mailing list