[PATCH] D100351: [CSSPGO] Fix a test issue due to portablity of std::hash

Hongtao Yu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 12 18:20:37 PDT 2021


hoy added a comment.

In D100351#2684602 <https://reviews.llvm.org/D100351#2684602>, @wenlei wrote:

> Thanks for the fix. How about using DAG check for things under other "Getting base profile for function" too?

Check-dag is added for _Z5funcAi and _Z5funcBi only since only the order of compiling _Z5funcAi and _Z5funcBi depends on std::hash. Both of them are children of main and there's no call from one of them to the other. Thus the top-down order is computed based on which one is traversed first during scc traversal. For the other two functions, main should be compiled first and _Z8funcLeafi should be compiled at last.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100351/new/

https://reviews.llvm.org/D100351



More information about the llvm-commits mailing list