[PATCH] D100137: [JumpThreading] merge debug info when merging select+br

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 12 16:52:21 PDT 2021


dblaikie added a comment.

In D100137#2684412 <https://reviews.llvm.org/D100137#2684412>, @nickdesaulniers wrote:

> Since https://reviews.llvm.org/D100158 is approved, are we still interested in this patch fixing what looks to me like a loss of debug info?

I'd be up for getting this fixed still - perhaps a more motivating test case would be if the two instructions had the same location, then the merged instruction should have that same location- a clear goodness, compared to the fuzzier "why does it matter that we managed to provide a line zero location on this instruction".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100137/new/

https://reviews.llvm.org/D100137



More information about the llvm-commits mailing list