[PATCH] D98103: [NPM] Do not run function simplification pipeline unnecessarily

Alina Sbirlea via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 12 15:37:45 PDT 2021


asbirlea added a comment.

I agree with @aeubanks on removing the NFC from the title. This is changing the functionality, even if it's under a disabled flag.

For additional context, with the flag enabled we're seeing performance regressions which indicate optimizations are being missed and picked up by the subsequent runs of the optimization pass.
The purpose of this initial patch is to stage the transition by first introducing the flag, then focus on understanding where the missed optimizations occur so we can fix (for lack of a better word) the NPM pass pipeline.
When the flag is eventually flipped, it's possible the compile-time benefits also disappear due to the introduction of additional optimization passes, but the current pathological cases of high compile times due to repeating (truly unnecessary) optimizations, should remain resolved.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98103/new/

https://reviews.llvm.org/D98103



More information about the llvm-commits mailing list