[PATCH] D100251: [IR][sanitizer] Set nounwind on module ctor/dtor, additionally set uwtable if -fasynchronous-unwind-tables

Mon Apr 12 13:34:17 PDT 2021

nickdesaulniers added a comment.

In D100251#2684083 <https://reviews.llvm.org/D100251#2684083>, @MaskRay wrote:

> In D100251#2684074 <https://reviews.llvm.org/D100251#2684074>, @nickdesaulniers wrote:
>
>>> -fno-exceptions -fno-asynchronous-unwind-tables -g produces .debug_frame
>>> while
>>> -fno-exceptions -fno-asynchronous-unwind-tables -g -fsanitize=address produces .eh_frame.
>>
>> Does this patch change that behavior?
>
> Yes. I consider `-fno-exceptions -fno-asynchronous-unwind-tables -g -fsanitize=address` producing `.eh_frame` is a bug. This patch will fix it and match GCC.

SGTM; please make that clearer though in the description.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100251/new/

https://reviews.llvm.org/D100251