[PATCH] D100132: [libunwind][AIX] Initial patch of the unwinder on AIX

[Xing Xue via Phabricator via llvm-commits]

xingxue added a comment.

Dear Reviewers.

The pre-commit check of this patch flagged `clang-format` and `clang-tidy` problems.

- The `clang-tidy` failures are related to using of undeclared identifier `UNW_STEP_END` and `UNW_STEP_SUCCESS`.  These macros are defined in `<libunwind_ext.h>`  without any guarding conditions. I was able to build the patch on a `PowerPC` Linux system running 'Ubuntu 18.04.5' as well as `AIX` successfully.  Maybe I missed something but I was unable to figure out why the `AIX` unwinder code would affect `UNW_STEP_END` and `UNW_STEP_SUCCESS`.  It would be greatly appreciated if you could provide guidance on resolving it.

- The `clang-format` flags the following issues `<assembly.h>`.  I cannot really put a space between `%` and `r` as suggested because this represent the registers in assembly language, e.g., `%r1`, `%f1`.  The assembler will complain if it is `% r1`, `% f1`.  Again, any help would be greatly appreciated.

  clang-format: please reformat the code
  
  -#define GPR(num) %r##num
  -#define FPR(num) %f##num
  -#define VSR(num) %vs##num
  -#define VR(num) %v##num
  +#define GPR(num) % r##num
  +#define FPR(num) % f##num
  +#define VSR(num) % vs##num
  +#define VR(num) % v##num


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100132/new/

https://reviews.llvm.org/D100132