[PATCH] D100257: [VPlan] Add VPUserID to distinguish between recipes and others.

[Andrei Elovikov via Phabricator via llvm-commits]

a.elovikov added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/VPlan.h:685
+  static inline bool classof(const VPUser *U) {
+    return U->getVPUserID() == VPUser::VPUserID::Recipe;
+  }
----------------
Can we make `getVPUserID()` protected instead of friendship above?


================
Comment at: llvm/lib/Transforms/Vectorize/VPlanValue.h:276
 
+static_assert(sizeof(VPUser) <= 48, "size of VPUser changed");
+
----------------
1) Why is that important? Do we rely on it or is it simply to prevent uncontrolled growth?
2) Why do we expect it to be the same on 32/64-bit platforms? Don't we have any pointers inside the object? I'd expect the vtable itself would make it different...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100257/new/

https://reviews.llvm.org/D100257