[PATCH] D99851: [SROA][TBAA] Handle shift of regular TBAA nodes

William Moses via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 12 11:37:04 PDT 2021


wsmoses added a comment.

Ah ok understood. And yes I completely agree that the patch as is would fail on this case (the patch as is essentially reverts the tbaa shift to the behavior prior to https://reviews.llvm.org/D95826 for TBAA nodes while retaining the correct behavior for tbaa.struct nodes).

I completely agree with doing a proper fix, especially if @jeroen.dobbelaere you have the cycles to do so right now. Is there anything I need to do to reassign this to you? For now I remain in a constant MLIR hackathon until the PACT deadline on Monday.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99851/new/

https://reviews.llvm.org/D99851



More information about the llvm-commits mailing list