[PATCH] D100176: [VPlan] Use recursive traversal iterator in VPSlotTracker.

Andrei Elovikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 12 11:33:44 PDT 2021


a.elovikov added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/VPlan.cpp:1243
+    if (!VPBB)
+      continue;
+    for (const VPRecipeBase &Recipe : *VPBB) {
----------------
I think that such usage would be the most common one (i.e. skipping the regions). Can we outline it into a separate helper somehow? The first idea coming to my mind is our custom `VPlanRPOT` class using the regular `RPOT` as a member and exposing iterators through `filter_iterator`, but maybe something nicer can be done as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100176/new/

https://reviews.llvm.org/D100176



More information about the llvm-commits mailing list