[PATCH] D98103: [NFC][NPM] Do not run function simplification pipeline unnecessarily

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added a comment.

nit with the summary, I think of "[NFC]" as more of refactoring types of changes, this adds new functionality under a flag



================
Comment at: llvm/lib/Analysis/CGSCCPassManager.cpp:557
     Function &F = N->getFunction();
+    if (FAM.getCachedResult<FunctionStatusAnalysis>(F))
+      continue;
----------------
adding a comment here would be good


================
Comment at: llvm/lib/Analysis/CGSCCPassManager.cpp:906
+
+  if (InvalidateSA)
+    FAM.invalidate<FunctionStatusAnalysis>(N.getFunction());
----------------
can this be `!FunctionPass`?


================
Comment at: llvm/lib/Passes/PassBuilder.cpp:18
 #include "llvm/Passes/PassBuilder.h"
+#include "llvm/ADT/ScopeExit.h"
 #include "llvm/ADT/StringSwitch.h"
----------------
unused?


================
Comment at: llvm/test/Other/new-pass-manager-cgscc-fct-proxy.ll:38
+
+; CHECK:          Starting CGSCC pass manager run.
+; CHCEK-NEXT:     Running pass: InlinerPass on (f3)
----------------
also check if we rerun SROA on f3?


================
Comment at: llvm/test/Other/new-pass-manager-cgscc-fct-proxy.ll:39
+; CHECK:          Starting CGSCC pass manager run.
+; CHCEK-NEXT:     Running pass: InlinerPass on (f3)
----------------
typo


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98103/new/

https://reviews.llvm.org/D98103