[compiler-rt] 15689f3 - [asan] Replaceable new/delete is unsupported in Windows.

[Mitch Phillips via llvm-commits]

Author: Mitch Phillips
Date: 2021-04-12T09:50:34-07:00
New Revision: 15689f3af018c420403bb0fd0df0aa5f79796b94

URL: https://github.com/llvm/llvm-project/commit/15689f3af018c420403bb0fd0df0aa5f79796b94
DIFF: https://github.com/llvm/llvm-project/commit/15689f3af018c420403bb0fd0df0aa5f79796b94.diff

LOG: [asan] Replaceable new/delete is unsupported in Windows.

Mark the test as unsupported to bring the bot online. Could probably be
permanently fixed by using one of the workarounds already present in
compiler-rt.

Added: 
    

Modified: 
    compiler-rt/test/asan/TestCases/replaceable_new_delete.cpp

Removed: 
    


################################################################################
diff  --git a/compiler-rt/test/asan/TestCases/replaceable_new_delete.cpp b/compiler-rt/test/asan/TestCases/replaceable_new_delete.cpp
index 405daf3d1be88..5de6c1ad8a683 100644
--- a/compiler-rt/test/asan/TestCases/replaceable_new_delete.cpp
+++ b/compiler-rt/test/asan/TestCases/replaceable_new_delete.cpp
@@ -1,5 +1,10 @@
 // Ensure that operator new/delete are still replaceable.
 
+// FIXME: Weak symbols aren't supported on Windows, although some code in
+// compiler-rt already exists to solve this problem. We should probably define
+// the new/delete interceptors as "weak" using those workarounds as well.
+// UNSUPPORTED: windows
+
 // RUN: %clangxx %s -o %t -fsanitize=address -shared-libsan && not %run %t 2>&1 | FileCheck %s
 // RUN: %clangxx %s -o %t -fsanitize=address -static-libsan && not %run %t 2>&1 | FileCheck %s