[PATCH] D100016: [GreedyRA ORE] Separate Folder Reloads and Zero Cost Folder Reloads

Francis Visoiu Mistrih via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 12 09:53:31 PDT 2021


thegameg added a comment.

In D100016#2678789 <https://reviews.llvm.org/D100016#2678789>, @skatkov wrote:

> @thegameg, I landed NFC before to move from if-else to if-continue. Is it readable now or you still want me to separate added logic into utility function?

I imagined all the checking ZeroCost/Patchpoint logic to be extracted in a separate function but it looks like it's more complicated than just a simple check.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100016/new/

https://reviews.llvm.org/D100016



More information about the llvm-commits mailing list