[PATCH] D99614: [flang] Update list-input test to use GTest

[Peter Klausler via Phabricator via llvm-commits]

klausler added a comment.

In D99614#2683137 <https://reviews.llvm.org/D99614#2683137>, @ashermancinelli wrote:

> @awarzynski Thanks again for the review! I have another patch ready to address this.
>
> I typically use `static` to reduce the number of initializations, but you're right to point out that in these tests readability is probably more important than saving a few ms (and most variables are PODs anyways).

It's good general practice to use `constexpr`, `static`, `static const`, &c.  Gratuitously avoiding good general practice makes code more surprising to a reader who knows C++ and good general practice, and that makes it less readable.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99614/new/

https://reviews.llvm.org/D99614