[PATCH] D94619: [SplitEdge] Update SplitCriticalEdge to return a nullptr only when the edge is not critical

Mon Apr 12 07:13:19 PDT 2021

sidbav added a comment.

In D94619#2673338 <https://reviews.llvm.org/D94619#2673338>, @lebedev.ri wrote:

> In D94619#2672562 <https://reviews.llvm.org/D94619#2672562>, @sidbav wrote:
>
>> In D94619#2672518 <https://reviews.llvm.org/D94619#2672518>, @lebedev.ri wrote:
>>
>>> Could use an IR test. Is only CoroFrame.cpp affected?
>>
>> Decided to use a unit test for this patch since I modified the functionality of SplitCriticalEdge and SplitEdge, and these functions are tested with unit tests.  Used a unit test to be consistent. 
>> CoroFrame.cpp, and BasicBlockUtils and BreakCriticalEdges are modified as well.
>
> This doesn't really answer my question, sorry.
> Which transformation passes benefit from this change?
> Can there not be a lit test for that for them?

Oh, I thought you were asking which files were changed!

CoroFrame.cpp is not really affected as this is more of a NFC for CoroFrame. 
However, quite a few other transformations that make use of SplitCriticalEdge and/or SplitEdge. I can create a lit test for those transformations.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94619/new/

https://reviews.llvm.org/D94619