[PATCH] D91516: [AMDGPU] Replace uses of LDS globals within non-kernel functions by pointers.

Mon Apr 12 05:27:05 PDT 2021

JonChesterfield added a comment.

In D91516#2655086 <https://reviews.llvm.org/D91516#2655086>, @hsmhsm wrote:

> In D91516#2643733 <https://reviews.llvm.org/D91516#2643733>, @JonChesterfield wrote:
>
>> This is much more complicated than I expected.
>> Is the large amount of comments largely from a previous patch doing different things that has been hammered into this one?
>
> No, nothing is hammered from the previous patch. The current patch is implementing what is planned via internal emial discussion.

This review dates from November 16 last year and contains hundreds of review comments against code that may or may not still be in the latest revision, this being diff #34 at time of commenting. If I'm following along successfully, the design has changed significantly and repeatedly during that process. It is therefore very difficult to determine what the design intent behind the current revision is. That is what I mean by 'previous patch has been hammered into this one'.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91516/new/

https://reviews.llvm.org/D91516