[PATCH] D100166: [PowerPC] stop reverse mem op generation when the feeder has more than one users

Nemanja Ivanovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 12 04:26:56 PDT 2021


nemanjai accepted this revision.
nemanjai added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:14375
+    // instruction, it is not profitable to replace it with a reverse store as
+    // the reverse store has no DForm.
+    if (!SVN->hasOneUse())
----------------
It is not clear why the fact that there is no D-Form makes this unprofitable.
Perhaps:
```
// If there are other uses of the shuffle, the swap cannot be avoided.
// Forcing the use of an X-Form (since swapped stores only have 
// X-Forms) without removing the swap is unprofitable.
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100166/new/

https://reviews.llvm.org/D100166



More information about the llvm-commits mailing list