[PATCH] D100203: [TTI] NFC: Change getCmpSelInstrCost to return InstructionCost

[Sander de Smalen via Phabricator via llvm-commits]

sdesmalen added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVTargetTransformInfo.cpp:165
   unsigned NumLoads = VTy->getNumElements();
-  InstructionCost MemOpCost =
+  unsigned MemOpCost =
       getMemoryOpCost(Opcode, VTy->getElementType(), Alignment, 0, CostKind, I);
----------------
dmgreen wrote:
> Merge gone off?
Yes, good catch. I've done a fair bit of rebasing of these patches, this one seems to have slipped through the cracks :)


================
Comment at: llvm/lib/Target/X86/X86TargetTransformInfo.cpp:3723
+                         CmpInst::BAD_ICMP_PREDICATE, CostKind);
+  return *Result.getValue();
 }
----------------
dmgreen wrote:
> This one was already converted to an InstructionCost too.
Thanks for pointing out, I'll try to be a bit more diligent with my other patches to spot these cases early!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100203/new/

https://reviews.llvm.org/D100203