[PATCH] D100015: [debug-info] make fortran CHARACTER(1) type as valid unsigned type

[ChenZheng via Phabricator via llvm-commits]

shchenz added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/DebugHandlerBase.cpp:180
+  if (isa<DIStringType>(Ty)) {
+    assert((Ty->getSizeInBits()) == 8 && "Not a valid unsigned type!");
+    return true;
----------------
aprantl wrote:
> It would be cleaner to reject this in Verifier and make it part of the general expectations for LLVM IR metadata.
Yes, agree. I am thinking we can add verifications for a `DbgValueInst` about the const value and the variable type. With these new verifications, we can expose this issue earlier. I will do this later in another patch when I get some time. Thanks for your review. @aprantl 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100015/new/

https://reviews.llvm.org/D100015